fix: fetch displayTitle and displaySubtitle for translations DHIS2-16216 #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2929--dhis2-data-visualizer.netlify.app |
1 flaky test on run #2691 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data dimension > displays Event data items correctly |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #2929 ↗︎
jenniferarnesen
approved these changes
Mar 6, 2024
edoardo
added a commit
that referenced
this pull request
Mar 19, 2024
edoardo
added a commit
that referenced
this pull request
Mar 19, 2024
dhis2-bot
added a commit
that referenced
this pull request
Mar 19, 2024
# [100.5.0](v100.4.0...v100.5.0) (2024-03-19) ### Bug Fixes * **translations:** sync translations from transifex (dev) ([dbb683f](dbb683f)) * fetch displayTitle and displaySubtitle for translations DHIS2-16216 ([#2929](#2929)) ([d6f327a](d6f327a)) * **push-analytics:** add push analytics instructions ([#2985](#2985)) ([77c5bcd](77c5bcd)) * **translations:** sync translations from transifex (dev) ([476e8a8](476e8a8)) * **translations:** sync translations from transifex (dev) ([459c53c](459c53c)) * **translations:** sync translations from transifex (dev) ([2966187](2966187)) * add custom errors for analytics requests ([#2874](#2874)) ([cc3fcd1](cc3fcd1)) ### Features * add class-names for push-analytics ([#2966](#2966)) ([5872a5a](5872a5a)) * support Outlier table visualization type (DHIS2-13858) ([#2942](#2942)) ([e9c31a7](e9c31a7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-16216
Requires dhis2/analytics#1597
Key features
Description
When translations are available for title and subtitle, they should be used instead of the original version.
These translations can be added in the Translations app.
TODO
Screenshots
Before:
After:
